Add support for unix style paths for secret paths #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
tegefaulkes
force-pushed
the
feature-eng-335-support-spaces-in-secret-paths
branch
2 times, most recently
from
da6974f
to
e5cf756
Compare
We allow most file paths now including spaces. We exclude `=` to allow the `path=whatever` format and `/` because `isomoric-git` doesn't handle it. [ci skip]
tegefaulkes
force-pushed
the
feature-eng-335-support-spaces-in-secret-paths
branch
from
e5cf756
to
b1b5030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses allowing spaces and other valid characters within the secret paths.
Issues Fixed
Tasks
Final checklist